Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meaningful name for MockServerConfigurer bean #14512

Closed
wants to merge 1 commit into from
Closed

Use meaningful name for MockServerConfigurer bean #14512

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Sep 19, 2018 •
edited
Loading

It looks accidentally named as get(), so this PR renames it to mockServerConfigurer().

@snicoll snicoll added the type: task A general task label Sep 19, 2018
@snicoll snicoll added this to the 2.1.0.M4 milestone Sep 19, 2018
@snicoll snicoll self-assigned this Sep 19, 2018
@snicoll snicoll closed this in fd97f07 Sep 19, 2018
snicoll added a commit that referenced this pull request Sep 19, 2018
@snicoll
Merge pull request #14512 from izeye:patch-50
32c4671 
* pr/14512:
  Use meaningful name for MockServerConfigurer bean
@snicoll
Copy link
Member

snicoll commented Sep 19, 2018

Good catch again, thanks @izeye!

@izeye izeye deleted the patch-50 branch September 19, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll approved these changes

Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
2.1.0.M4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izeye @snicoll