Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolve health groups #16252

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

No description provided.

@wilkinsona
Copy link
Member

Thanks for the PR, @eddumelendez. This seems to be taking a different approach to the one described in this comment. If you tried the approach described there, can you please let us know why it didn't work out and why you chose this approach instead?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Mar 19, 2019
@eddumelendez
Copy link
Contributor Author

sorry for the delay @wilkinsona. I had in mind the approach discussed in the issue which I can understand is not reflected into this PR. But, this is an initial draft indeed, this PR is missing the configuration through application.properties. Hope this part is ok so I can proceed with the missing parts.

@wilkinsona
Copy link
Member

Thanks, @eddumelendez. I am struggling to understand how the configuration of health indicator groups will map onto the changes that you have proposed thus far. For example, I had not expected the health endpoint to have an operation that takes a list of components added to it. Instead, we had anticipated that each configured group would result in a new composite health indicator being created:

We then thought that CompositeHealthIndicator could be reused and created with all the health indicators in the group. One gotcha that @philwebb identified is that these composite health indicators that represent a group will need to be hidden from the main health check otherwise any grouped indicators would be called twice for a single check.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 29, 2019
@snicoll
Copy link
Member

snicoll commented Jun 21, 2019

@eddumelendez I've made quite some progress (see #14022) and this draft hasn't moved in a while so I am closing it now. If you have time to look at the current proposal, your feedback is more than welcome. Thanks for the PR, in any case!

@snicoll snicoll closed this Jun 21, 2019
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants