-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThymeleafAutoConfiguration fails if thymeleaf-spring5 is not present #16341
ThymeleafAutoConfiguration fails if thymeleaf-spring5 is not present #16341
Conversation
This commit adds an extra check for the presence of thymeleaf-spring5 library on the classpath. Since now ThymeleafAutoConfiguration is considered only if both thymeleaf-spring5 and thymeleaf jars are present. spring-projectsgh-16079
The current code base from master does not build. You can spot this build failure in the latest builds:
I was able to reproduce it locally with the following configuration: JVM/Maven:
Git revision Let me know if it's a known case or if I should raise an issue for it. |
Thank you. As you’ve seen yourself CI has been failing, probably due to a change in a snapshot dependency. We are aware of it and will work on a fix. |
* pr/16341: Add missing class condition on thymeleaf-spring5
@koziolk thank you for making your first contribution to Spring Boot. Your work has been merged in |
This commit adds an extra check for the presence of thymeleaf-spring5
library on the classpath. Since now ThymeleafAutoConfiguration is
considered only if both thymeleaf-spring5 and thymeleaf jars are present.
gh-16079