Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify starter validation dependencies and make validation easier to exclude from WebFlux applications #16593

Closed
wants to merge 1 commit into from
Closed

Simplify starter validation dependencies and make validation easier to exclude from WebFlux applications #16593

wants to merge 1 commit into from

Conversation

pkostrzewa
Copy link
Contributor

@pkostrzewa pkostrzewa commented Apr 17, 2019 •
edited

Closes #16582

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 17, 2019
@snicoll snicoll mentioned this pull request Apr 17, 2019
Closed
@wilkinsona
Copy link
Member

Thanks very much for the PR. Reviewing the proposed change has made me realise that we're missing an EL implementation in the WebFlux starter. I've opened #16596. We'll need to figure that one out before we can merge this.

@wilkinsona wilkinsona mentioned this pull request Apr 18, 2019
Closed
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 18, 2019
@wilkinsona wilkinsona added this to the 2.2.0.M3 milestone Apr 18, 2019
@wilkinsona wilkinsona self-assigned this Apr 18, 2019
wilkinsona pushed a commit that referenced this pull request Apr 18, 2019
@wilkinsona
Update WebFlux starter to depend on validation starter
ff7cf2d 
Previously, the WebFlux starter declared direct dependencies on Hibernate Validator
and the Jakarta EE validation API. This meant that it required two exclusions to
exclude validation from a reactive web application that did not need it.

This commit updates the WebFlux starter to get its validation dependencies via a
dependency on the validation starter. This allows validation to be excluded
using a single exclusion. The EL dependency from the validation starter has
been excluded to allow the EL implementation from the underlying container
starter to continue to be used instead.

See gh-16593
@wilkinsona
Copy link
Member

Thanks again for the PR, @pkostrzewa. The proposed changes have now been merged into master.

@YoKv YoKv mentioned this pull request May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M3
Development

Successfully merging this pull request may close these issues.

Simplify starter validation dependencies and make validation easier to exclude from WebFlux applications
3 participants
@pkostrzewa @wilkinsona @spring-projects-issues