#16: Added wildcard and property placeholder supoprt in the SpringApplic... #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks. |
|
Re-opened (tests failing). I rewrote history on master to get rid of this change. Can you pick it up from there and fix the test please? |
…n the SpringApplication String defined sources * Default resource loaded in the BeanDefinitionLoader has been changed to PathMatchingResourcePatternResolver; * A check for the ResourcePatternLoader similar to that in AbstractBeanDefinitionReader and property placeholder resolution has been added to the load(CharSequence) method of the BeanDefinitionLoader; * Added a unit test illustrating the issue;
|
Hi Dave, sorry. I've updated the PR, it should pass the tests now. |
|
Merged again, thanks. |
wilkinsona
added a commit
to wilkinsona/spring-boot
that referenced
this pull request
Nov 3, 2016
W0rf
referenced
this pull request
in W0rf/jenkins2-course-spring-boot
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ation String defined sources