Make logError() in AbstractErrorWebExceptionHandler overrideable #17863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
This is related to #12414. |
philwebb
added
for: team-attention
wilkinsona
pushed a commit
that referenced
this pull request
Sep 5, 2019
wilkinsona
added a commit
that referenced
this pull request
Sep 5, 2019
|
Thank you very much for making your first contribution to Spring Boot, @peterjurkovic. I also pushed a small polishing commit to add some javadoc and restore the original method order so that they're ordered by use rather than visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subclass extending of
AbstractErrorWebExceptionHandlercan't overridelogError(). We would like to change logging behavior in a subclass, but unfortunately is not quite easy, we would have to duplicate a lot of useful code in that class.Can we please make
AbstractErrorWebExceptionHandler.logError(..)protected? Unless there is a serious reason to make it private.