Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-configure Flyway with any JavaMigration beans #17993

Closed
wants to merge 2 commits into from
Closed

Auto-configure Flyway with any JavaMigration beans #17993

wants to merge 2 commits into from

Conversation

SammyVimes
Copy link
Contributor

@SammyVimes SammyVimes commented Aug 29, 2019 •
edited
Loading

This pull request fixes #15446. Added java migration autoconfiguration.

@pivotal-issuemaster
Copy link

@SammyVimes Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@SammyVimes Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 29, 2019
@wilkinsona
Copy link
Member

Thanks very much for the pull request, @SammyVimes. Would you mind splitting it into two, one for each commit? I'd like the closed issues and pull requests to shows the upgrade to Flyway 6 and the addition of support for auto-configuring Java migrations as two separate things.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Aug 29, 2019
@SammyVimes
Copy link
Contributor Author

Of course, I'll do it right away

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 29, 2019
@SammyVimes SammyVimes force-pushed the flyway-autoconfigure-java-migrations branch from 63690ec to 2be87ee Compare August 29, 2019 12:55
@SammyVimes
Copy link
Contributor Author

SammyVimes commented Aug 29, 2019 •
edited
Loading

Created new pull request (with flyway 6 only) #17997.

Update: turns out flyway property test fails, I will fix it by the week's end

@SammyVimes SammyVimes force-pushed the flyway-autoconfigure-java-migrations branch from 2be87ee to f5337e6 Compare August 29, 2019 21:56
@SammyVimes
Copy link
Contributor Author

I fixed tests related to flyway, but It looks like some tests are unstable in master, so the build is not passing :(

@philwebb
Copy link
Member

@SammyVimes Sorry about that, our CI box ran out of diskspace.

@wilkinsona wilkinsona changed the title Flyway autoconfigure java migrations Auto-configure Flyway with any JavaMigration beans Aug 30, 2019
@wilkinsona wilkinsona self-assigned this Aug 30, 2019
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Aug 30, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone Aug 30, 2019
@wilkinsona wilkinsona mentioned this pull request Aug 30, 2019
Closed
@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.0.M6 Aug 30, 2019
wilkinsona pushed a commit that referenced this pull request Aug 30, 2019
@SammyVimes @wilkinsona
Auto-configure Flyway with JavaMigration beans
ff68295 
See gh-17993
wilkinsona added a commit that referenced this pull request Aug 30, 2019
@wilkinsona
Polish "Auto-configure Flyway with JavaMigration beans"
e2edb6a 
See gh-17993
@wilkinsona
Copy link
Member

Thanks again, @SammyVimes.

pull bot pushed a commit to scope-demo/spring-boot that referenced this pull request Aug 30, 2019
@SammyVimes @pull
Auto-configure Flyway with JavaMigration beans
3abc842 
See spring-projectsgh-17993
pull bot pushed a commit to scope-demo/spring-boot that referenced this pull request Aug 30, 2019
@wilkinsona @pull
Polish "Auto-configure Flyway with JavaMigration beans"
f004338 
See spring-projectsgh-17993
@happygrizzly
Copy link

How do I get these changes into my project? I'm using 2.1.7 RELEASE version.

@wilkinsona
Copy link
Member

You'll have to upgrade to 2.2. The changes are in 2.2.0 snapshots and will be in 2.2.0.M6 which is scheduled for early next month.

@happygrizzly
Copy link

You'll have to upgrade to 2.2. The changes are in 2.2.0 snapshots and will be in 2.2.0.M6 which is scheduled for early next month.

Does this mean I'll have to wait for M6 to be done?

@happygrizzly
Copy link

happygrizzly commented Aug 30, 2019 •
edited
Loading

You'll have to upgrade to 2.2. The changes are in 2.2.0 snapshots and will be in 2.2.0.M6 which is scheduled for early next month.

Well, I think I can temporarily downgrade the flyway dependency. Thank you!

@geoffreywiseman geoffreywiseman mentioned this pull request Aug 30, 2019
Closed
@serenaponta serenaponta mentioned this pull request Sep 13, 2019
Merged
@wilkinsona wilkinsona mentioned this pull request Oct 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M6
Development

Successfully merging this pull request may close these issues.

Transparently integrate Flyway 6.0's support JavaMigration instances created by DI frameworks
6 participants
@SammyVimes @pivotal-issuemaster @wilkinsona @philwebb @happygrizzly @spring-projects-issues