Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@TestConfiguration disables proxying of @Bean methods #18675

Closed
wants to merge 1 commit into from
Closed

@TestConfiguration disables proxying of @Bean methods #18675

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Oct 21, 2019

See gh-18653

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 21, 2019
@wilkinsona wilkinsona mentioned this pull request Oct 21, 2019
Closed
@wilkinsona wilkinsona changed the title Add 'proxyBeanMethods' attribute to @TestConfiguration and enable it by default @TestConfiguration disables proxying of @Bean methods Oct 21, 2019
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 21, 2019
@wilkinsona wilkinsona added this to the 2.2.1 milestone Oct 21, 2019
@snicoll snicoll self-assigned this Oct 22, 2019
snicoll pushed a commit that referenced this pull request Oct 22, 2019
@nosan @snicoll
Restore proxying of @bean methods in @TestConfiguration
7faa606 
See gh-18675
snicoll added a commit that referenced this pull request Oct 22, 2019
@snicoll
Polish "Restore proxying of @bean methods in @TestConfiguration"
fd94608 
See gh-18675
@snicoll snicoll closed this in afc87b7 Oct 22, 2019
@snicoll
Copy link
Member

snicoll commented Oct 22, 2019

Thanks @nosan. I've polished the tests and added the attribute again in our own use of the annotation.

@nosan
Copy link
Contributor Author

nosan commented Oct 22, 2019

Thanks @snicoll,

added the attribute again in our own use of the annotation.

I've completely forgotten about this :(

@nosan nosan deleted the gh-18653 branch October 22, 2019 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nosan @snicoll @wilkinsona @spring-projects-issues