Polish note about handling of caches that are created on-the-fly #19491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Dec 31, 2019
| @@ -1849,7 +1849,7 @@ The following cache libraries are supported: | |||
| Metrics are tagged by the name of the cache and by the name of the `CacheManager` that is derived from the bean name. | |||
|
|
|||
| NOTE: Only caches that are configured on startup are bound to the registry. | |||
| For caches not defined in the cache’s configuration, that is caches created on-the-fly or programmatically after the startup phase, an explicit registration is required. | |||
| For caches not defined in the cache’s configuration, that are created on-the-fly or programmatically after the startup phase, an explicit registration is required. | |||
There was a problem hiding this comment.
I really meant "that is" as "i.e.". Perhaps there's a missing comma somewhere?
There was a problem hiding this comment.
@snicoll I'm not an English native speaker, either 😅 I just thought that the "that" clause was meant to be for the "caches" as "that is caches" sounded unusual to me. I might be wrong here.
There was a problem hiding this comment.
OK. I am not sure either :) Would you be happy with
For caches not defined in the cache’s configuration, e.g. caches created on-the-fly or programmatically after the startup phase, ...
There was a problem hiding this comment.
@snicoll Sounds better to me 😄
There was a problem hiding this comment.
Sweet, would you be willing to update your proposal with that please?
snicoll
added
the
status: waiting-for-feedback
snicoll
pushed a commit
that referenced
this pull request
Dec 31, 2019
This was referenced Dec 31, 2019
snicoll
added
type: documentation
wilkinsona
changed the title
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes doc a bit.