Clarify the type to which connection-pool-specific spring.datasource properties are bound
#20727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Hikari Datasource properties Fixes spring-projectsgh-20688
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Mar 30, 2020
.../java/org/springframework/boot/build/context/properties/DocumentConfigurationProperties.java
Outdated
Show resolved
Hide resolved
wilkinsona
added
the
status: waiting-for-feedback
wilkinsona
added
type: documentation
wilkinsona
changed the title
spring.datasource.hikari.* properties are bound to a HikariDataSource instance
wilkinsona
changed the title
spring.datasource.hikari.* properties are bound to a HikariDataSource instancespring.datasource properties are bound
wilkinsona
changed the title
spring.datasource properties are boundspring.datasource properties are bound
wilkinsona
pushed a commit
that referenced
this pull request
Mar 31, 2020
wilkinsona
added a commit
that referenced
this pull request
Mar 31, 2020
|
Thanks very much for making your first contribution to Spring Boot, @parameswaranvv. In reviewing the changes, I realised that they were applicable to Commons DBCP2 and Tomcat JDBC as well. I made similar updates for both of those in a polishing commit. I also had to drop the use of backticks around the class name as the column in the table was rendering them as-is. Apologies for the bad suggestion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue: #20688, Minor change to description of Hikari Datasource properties in documentation
Fixes gh-20688