Refactor CacheConfigurations to avoid storing configuration classes #25321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors CacheConfigurations implementation to make it more native friendly by storing strings instead of classes in order to avoid loading the configuration classes when CacheConfigurations is initialized at build time.
spring-projects-issues
added
the
status: waiting-for-triage
|
As discussed with @snicoll there are various pending design questions about caching support in Spring Native, so probably better to wait before merging this PR. Feel free to close it for now or maybe to tag it accordingly. |
|
Thanks for the PR and the discussion! Given the contract of the public API that change looks good to me but if you need this for |
|
Looking again, I've changed my mind as this makes more sense to store the FQN since anyway the API is working on that and not the class. |
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Feb 18, 2021
This commit refactors CacheConfigurations implementation to make it more native friendly by storing strings instead of classes in order to avoid loading the configuration classes when CacheConfigurations is initialized at build time. See gh-25321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors
CacheConfigurationsimplementation to make it more native friendly by storing strings instead of classes inorder to avoid loading the configuration classes when
CacheConfigurationsis initialized at build time.