Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot Starter for Spring Social Google #2548

Closed
wants to merge 6 commits into from

Conversation

jiwhiz
Copy link

@jiwhiz jiwhiz commented Feb 25, 2015

I'm using Spring Social Google in my project, and would like to have a spring boot starter for that.

@philwebb
Copy link
Member

Thanks, have you signed the CLA?

@philwebb philwebb added this to the 1.3.0 milestone Feb 25, 2015
@philwebb philwebb added the type: enhancement A general enhancement label Feb 25, 2015
@jiwhiz
Copy link
Author

jiwhiz commented Feb 25, 2015

Yes, did that long time ago when I worked with spring social security.

@philwebb
Copy link
Member

@jiwhiz Thanks, but could you also sign the Spring Boot CLA. I think they are the same but I'd like to make sure that we have all bases covered.

@jiwhiz
Copy link
Author

jiwhiz commented Feb 25, 2015

@philwebb Signed the Spring Boot CLA. Got response:

Hello Yuan Ji

Thank you but our records indicate that you have already accepted the individual
contributor agreement. If you are interested in participating in an additional
Spring project, please contact the appropriate project lead and indicate that
you have already signed the Spring Contributor Agreement. Once signed
agreement covers participating in as many Spring projects as you need.

Your confirmation number is: 40020121213084106

@philwebb
Copy link
Member

OK, Thanks. My mistake, it looks like the CLA covers all projects.

@wilkinsona
Copy link
Member

As things stand, I'm not sure that we should merge this.

The project's group id is org.springframework.social but, AFAIK, it isn't an official Spring project. It isn't listed in the Spring Social README and isn't in the Spring Projects GitHub organisation. I'm wary of creating the wrong impression regarding the Spring team's involvement with the project. I'd be more comfortable if the project wasn't being published in "our" group id.

/cc @habuma

@jiwhiz
Copy link
Author

jiwhiz commented Apr 8, 2015

Hmm... Spring Social Google is already under group id of "org.springframework.social". Since it is so important, is it possible to move it into spring-projects? I think it will benefit all of us.

/cc @GabiAxel @habuma

@jiwhiz
Copy link
Author

jiwhiz commented Apr 13, 2015

So @GabiAxel is OK to move spring-social-google to spring-projects. Is it @habuma 's call now?

@wilkinsona wilkinsona removed this from the 1.3.0 milestone May 13, 2015
@wilkinsona
Copy link
Member

Thanks for the PR. We've discussed this and decided that we don't want to add support for spring-social-google to Spring Boot. As an alternative, you may want to consider contributing the auto-configuration to the spring-social-google project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on-hold We can't start working on this issue yet type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants