Avoid illegal reflective access in RabbitAutoConfigurationTests #26954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Jun 22, 2021
|
Thanks @dreis2211, I am not a big fan of asserting the console output but, looking at the previous version, I think it's an acceptable trade-off. |
|
Me neither, @snicoll . But thanks for accepting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is an attempt to avoid some illegal reflective access in
RabbitAutoConfigurationTests. The idea is that rather than using reflection in order to get down to the usedTrustManagerwe look for output thatTrustEverythingTrustManageris producing when in use. It's not pretty, but it works and is reflection free. It's also the least invasive option without opening modules and/or changing the production code that I could find.As this is part of the overall JDK 17 story under #26767, it should probably go into 2.5.x.
Let me know what you think.
Cheers,
Christoph