Expose Stackdriver's useSemanticMetricTypes property #28403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jonatan-ivanov
commented
Oct 20, 2021
| @@ -71,4 +79,12 @@ public void setResourceLabels(Map<String, String> resourceLabels) { | |||
| this.resourceLabels = resourceLabels; | |||
| } | |||
|
|
|||
| boolean isUseSemanticMetricTypes() { | |||
There was a problem hiding this comment.
This feels weird.
| @@ -47,6 +47,14 @@ | |||
| */ | |||
| private Map<String, String> resourceLabels; | |||
|
|
|||
| /** | |||
| * Whether to use semantically correct metric types. When this is false, counter | |||
There was a problem hiding this comment.
I'm thinking if we should document this in more (or less) details, see:
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Oct 21, 2021
wilkinsona
added a commit
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes 'useSemanticMetricTypes' property for Stackdriver, recently added to Micrometer: