Make endpoint web extensions conditional on endpoint being exposed over HTTP #28475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
approved these changes
Oct 28, 2021
There was a problem hiding this comment.
This looks good. Thanks very much for the PR, @davidh44.
I've left a few comments. There's no need to act upon them, particularly those that were caused by unnecessary initializer in my example test, unless you really want to. We can polish things up when we merge your contribution.
...onfigure/context/properties/ConfigurationPropertiesReportEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...g/springframework/boot/actuate/autoconfigure/cache/CachesEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...pringframework/boot/actuate/autoconfigure/env/EnvironmentEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../springframework/boot/actuate/autoconfigure/quartz/QuartzEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...onfigure/context/properties/ConfigurationPropertiesReportEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/boot/actuate/autoconfigure/cache/CachesEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...autoconfigure/context/properties/ConfigurationPropertiesReportEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...org/springframework/boot/actuate/autoconfigure/env/EnvironmentEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/quartz/QuartzEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
wilkinsona
changed the title
wilkinsona
added
type: task
|
@wilkinsona Thanks for the feedback! I made the suggested changes and made a new commit to my fork. |
wilkinsona
removed
the
for: merge-with-amendments
snicoll
pushed a commit
that referenced
this pull request
Nov 16, 2021
This commit updates Actuator's EndpointWebExtensions to be created only if the related endpoint is exposed over HTTP. See gh-28475
snicoll
added a commit
that referenced
this pull request
Nov 16, 2021
|
@davidh44 thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er HTTP