-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make endpoint web extensions conditional on endpoint being exposed over HTTP #28475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks very much for the PR, @davidh44.
I've left a few comments. There's no need to act upon them, particularly those that were caused by unnecessary initializer in my example test, unless you really want to. We can polish things up when we merge your contribution.
...onfigure/context/properties/ConfigurationPropertiesReportEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...g/springframework/boot/actuate/autoconfigure/cache/CachesEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...pringframework/boot/actuate/autoconfigure/env/EnvironmentEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../springframework/boot/actuate/autoconfigure/quartz/QuartzEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...onfigure/context/properties/ConfigurationPropertiesReportEndpointAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/boot/actuate/autoconfigure/cache/CachesEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...autoconfigure/context/properties/ConfigurationPropertiesReportEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...org/springframework/boot/actuate/autoconfigure/env/EnvironmentEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/quartz/QuartzEndpointAutoConfiguration.java
Outdated
Show resolved
Hide resolved
@wilkinsona Thanks for the feedback! I made the suggested changes and made a new commit to my fork. |
This commit updates Actuator's EndpointWebExtensions to be created only if the related endpoint is exposed over HTTP. See gh-28475
@davidh44 thank you for making your first contribution to Spring Boot. |
…er HTTP