Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make endpoint web extensions conditional on endpoint being exposed over HTTP #28475

Closed
wants to merge 2 commits into from

Conversation

davidh44
Copy link
Contributor

…er HTTP

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 28, 2021
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks very much for the PR, @davidh44.

I've left a few comments. There's no need to act upon them, particularly those that were caused by unnecessary initializer in my example test, unless you really want to. We can polish things up when we merge your contribution.

@wilkinsona wilkinsona changed the title Make endpoint web extensions conditional on endpoint being exposed ov… Make endpoint web extensions conditional on endpoint being exposed over HTTP Oct 28, 2021
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 28, 2021
@wilkinsona wilkinsona added this to the 2.6.x milestone Oct 28, 2021
@wilkinsona wilkinsona added the for: merge-with-amendments Needs some changes when we merge label Oct 28, 2021
@davidh44
Copy link
Contributor Author

davidh44 commented Nov 2, 2021

@wilkinsona Thanks for the feedback! I made the suggested changes and made a new commit to my fork.

@wilkinsona wilkinsona removed the for: merge-with-amendments Needs some changes when we merge label Nov 8, 2021
@snicoll snicoll self-assigned this Nov 16, 2021
snicoll pushed a commit that referenced this pull request Nov 16, 2021
This commit updates Actuator's EndpointWebExtensions to be created only
if the related endpoint is exposed over HTTP.

See gh-28475
@snicoll snicoll closed this in 62d87f9 Nov 16, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.0 Nov 16, 2021
@snicoll
Copy link
Member

snicoll commented Nov 16, 2021

@davidh44 thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants