Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ConditionalOnMissingFilterBean on tomcatForwardedHeaderFilterCustomizer() #29983

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Feb 24, 2022

This PR removes @ConditionalOnMissingFilterBean(ForwardedHeaderFilter.class) on tomcatForwardedHeaderFilterCustomizer() @Bean method as it seems to have been added accidentally.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 24, 2022
@snicoll snicoll changed the title Remove ConditionalOnMissingFilterBean on tomcatForwardedHeaderFilterCustomizer() Remove duplicate ConditionalOnMissingFilterBean on tomcatForwardedHeaderFilterCustomizer() Feb 24, 2022
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 24, 2022
@snicoll snicoll added this to the 2.5.x milestone Feb 24, 2022
@izeye
Copy link
Contributor Author

izeye commented Feb 25, 2022

ServletWebServerFactoryAutoConfigurationTests.relativeRedirectsShouldBeEnabledWhenUsingTomcatContainerAndUseRelativeRedirects() has failed in this PR's build as follows:

> Task :spring-boot-project:spring-boot-autoconfigure:test FAILED

Found test failures in 1 test task:

:spring-boot-project:spring-boot-autoconfigure:test
    org.springframework.boot.autoconfigure.web.servlet.ServletWebServerFactoryAutoConfigurationTests > relativeRedirectsShouldBeEnabledWhenUsingTomcatContainerAndUseRelativeRedirects()

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':spring-boot-project:spring-boot-autoconfigure:test'.
> There were failing tests. See the report at: file:///tmp/build/6da1d659/git-repo/spring-boot-project/spring-boot-autoconfigure/build/reports/tests/test/index.html

I'm not sure why it has failed. I can't reproduce it with either IDE (IntelliJ) or Gradle locally. I might miss something here.

@wilkinsona
Copy link
Member

I don't understand why that's happening either. The annotation that you've removed should be redundant as it's already present on ForwardedHeaderFilterConfiguration.

@wilkinsona
Copy link
Member

Thanks very much, @izeye. I too have failed to reproduce the failure locally. I also triggered a repeat CI build and it passed. We'll keep an eye out for the test being flaky and investigate if it happens again.

@izeye izeye deleted the remove branch March 2, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants