Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the Dynatrace instruments in Micrometer #30637

Conversation

joaopgrassi
Copy link

In the Micrometer PR micrometer-metrics/micrometer#3093 we introduced a couple of custom built instruments in order to export metrics in the most optimal format. These new instruments are the ones used by default starting from Micrometer 1.9.0.

This PR introduces a new flag, that allow users to switch back to the previous behavior - where the original instruments from Micrometer are used.

Since Micrometer version 1.9.0, the Dynatrace registry uses specialized
instruments by default, which ensures data is exported in an optimal
format. By using this new flag, users can switch back to the previous
behavior, which uses the original instruments from Micrometer.
@joaopgrassi joaopgrassi changed the title Allow disabling the Dynatrace instruments Allow disabling the Dynatrace instruments in Micrometer Apr 11, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 11, 2022
@joaopgrassi
Copy link
Author

Hi @snicoll!

For this PR to be part of the 2.7 release, should I target it towards main or 2.7.x? Thanks :)

@scottfrederick
Copy link
Contributor

@joaopgrassi We can take care of merging to the appropriate branch when we decide which release to include it in.

@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged label Apr 19, 2022
@snicoll snicoll self-assigned this Apr 19, 2022
@snicoll snicoll added this to the 2.7.0-RC1 milestone Apr 19, 2022
@snicoll snicoll added the type: enhancement A general enhancement label Apr 19, 2022
snicoll pushed a commit that referenced this pull request Apr 19, 2022
Since Micrometer version 1.9.0, the Dynatrace registry uses specialized
instruments by default, which ensures data is exported in an optimal
format. By using this new flag, users can switch back to the previous
behavior, which uses the original instruments from Micrometer.

See gh-30637
snicoll added a commit that referenced this pull request Apr 19, 2022
@snicoll snicoll closed this in c2f2bde Apr 19, 2022
@snicoll
Copy link
Member

snicoll commented Apr 19, 2022

@joaopgrassi thank you for making your first contribution to Spring Boot.

@joaopgrassi joaopgrassi deleted the add-dynatrace-instruments-toggle branch April 19, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants