Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug logging for requests to WebFlux-based Actuator endpoints does not identify the endpoint #30880

Conversation

christophejan
Copy link
Contributor

@wilkinsona
Copy link
Member

Without this change, log messages are like this:

2022-05-06 15:13:07.751 DEBUG 34391 --- [ctor-http-nio-3] .b.a.e.w.r.WebFluxEndpointHandlerMapping : [285cdf1d-2] Mapped to org.springframework.boot.actuate.endpoint.web.reactive.AbstractWebFluxEndpointHandlerMapping$ReadOperationHandler@1d3bc254

With these changes applied, the debug message is then like this:

2022-05-06 15:14:55.644 DEBUG 34520 --- [ctor-http-nio-2] .b.a.e.w.r.WebFluxEndpointHandlerMapping : [20c7a545-1] Mapped to Actuator web endpoint 'health'

With MVC, the log output already looks like this:

2022-05-06 15:17:38.702 DEBUG 34603 --- [nio-8080-exec-3] s.b.a.e.w.s.WebMvcEndpointHandlerMapping : Mapped to Actuator web endpoint 'health'

This will further the changes made in 8e86bca for #14292.

@wilkinsona wilkinsona changed the title Add toString to spring-boot-actuator WriteOperationHandler and ReadOperationHandler Debug logging for requests to WebFlux-based Actuator endpoints does not identify the endpoint May 6, 2022
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 6, 2022
@wilkinsona wilkinsona added this to the 2.5.14 milestone May 6, 2022
@wilkinsona wilkinsona self-assigned this May 6, 2022
@wilkinsona
Copy link
Member

@christophejan Thanks very much for making your first contribution to Spring Boot.

@christophejan christophejan deleted the add-to-string-to-actuator-operation-handler branch May 8, 2022 13:33
@christophejan
Copy link
Contributor Author

@wilkinsona A much better argumentation than mine. Thank you !

ps : it's always a pleasure to read your point of view, alway precise, with clear explanation and vision. A lot of thanks !

@wilkinsona
Copy link
Member

That's very kind of you to say, thank you. And thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants