Remove unused code in GitInfoContributor #31903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the `info` Actuator endpoint doesn't support/use the `git.build.time` property.
spring-projects-issues
added
the
status: waiting-for-triage
|
@dalbani that's the output for the simple mode. When it outputs the full data, there is a |
snicoll
added
status: declined
|
Thanks a lot @snicoll for this super fast and helpful feedback 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the documentation at https://docs.spring.io/spring-boot/docs/current/actuator-api/htmlsingle/#info.retrieving.response-structure.git, the
infoActuator endpoint doesn't include abuild.timein the response.Yet, in
GitInfoContributor::postProcessContent(), the method looks for abuild.timeproperty that thus never exists, because it's not retained in thetoSimplePropertySource()method above.The line of code in question doesn't break anything but it has no effect either.
That's why I suggest removing it altogether for clarity.