Prefer WebClient to RestTemplate when creating the Zipkin Sender #32529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
marcingrzejszczak
force-pushed
the
httpClientZipkinOrderChange
branch
from
1d3dd55
to
219e137
Compare
without this change we're registering WebClient sender only for webflux applications and we fallback to a RestTemplate sender in all the other cases with this change we're always trying to register a WebClient sender and fallback to RestTemplate only when WebClient is not on the classpath
marcingrzejszczak
force-pushed
the
httpClientZipkinOrderChange
branch
from
219e137
to
9006396
Compare
wilkinsona
changed the title
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Sep 28, 2022
Previously, a Webclient-based sender was only for reactive web applications, falling back to a RestTemplate-based sender in all other cases. With this commit we now prefer to use WebClient if it is available, irrespective of the web application type. The assumption is that if the user has WebClient on the classpath, it's either a reactive web application, or it's a servlet web application or non-web application but WebClient is preferred. See gh-32529
wilkinsona
added a commit
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change we're registering WebClient sender only for webflux applications and we fallback to a RestTemplate sender in all the other cases
with this change we're always trying to register a WebClient sender and fallback to RestTemplate only when WebClient is not on the classpath