Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Mockito argument captors with assertArg #35015

Closed
wants to merge 1 commit into from

Conversation

Ckram
Copy link
Contributor

@Ckram Ckram commented Apr 17, 2023

Replace Mockito argument captors with assertArg

Fixes #34943

@pivotal-cla
Copy link

@Ckram Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@Ckram Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 17, 2023
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 17, 2023
@snicoll snicoll added this to the 3.1.x milestone Apr 17, 2023
@mhalbritter mhalbritter self-assigned this May 5, 2023
mhalbritter pushed a commit that referenced this pull request May 5, 2023
@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.0 May 5, 2023
wilkinsona pushed a commit to wilkinsona/spring-boot that referenced this pull request May 5, 2023
wilkinsona added a commit to wilkinsona/spring-boot that referenced this pull request May 5, 2023
@wilkinsona
Copy link
Member

I think there are some more places where we can use assertArg. I started polishing in wilkinsona@33b8dfb I stopped as I reached a place where mockito/mockito#2982 would be useful. I think it'd be nice to move over everywhere we can without the enhancement though.

mhalbritter added a commit that referenced this pull request May 5, 2023
Co-authored-by: Andy Wilkinson <wilkinsona@vmware.com>

See gh-35015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Mockito argument captors with assertArg
6 participants