Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed types for Neo4j are not used in Neo4j Data auto configuration #37574

Closed
wants to merge 1 commit into from

Conversation

michael-simons
Copy link
Contributor

This fixes #37573.

I tested the fix locally in native image mode and added a test that reliable fails without using Neo4jManagedTypes proper.
I don't know whether you run the integration tests in native mode, or put them somewhere else. If the latter is the case, please point me where I can move this or feel free to move it around yourself.

I suggest back porting this to 3.1 and 3.0 (I think 3.0 already managed SDN 7, including the dedicated managed types).

Thanks a lot!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 25, 2023
@wilkinsona wilkinsona changed the title Use Neo4jManagedTypes to populate the mapping context. Managed types for Neo4j are not used in Neo4j Data auto configuration Sep 25, 2023
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 25, 2023
@wilkinsona wilkinsona added this to the 3.0.x milestone Sep 25, 2023
@wilkinsona
Copy link
Member

https://github.com/spring-projects/spring-aot-smoke-tests would be a good place for the new test. Having looked there just now, I've noticed that we don't have any coverage for SDN. Setting up a new project in the smoke tests is a little bit involved so we can take a look at that and copy over something that's equivalent to the test proposed here.

@michael-simons
Copy link
Contributor Author

michael-simons commented Sep 25, 2023

Hu… I'm quite sure I did run the format check (and check style afterwards…) 👀

Edit: Aaah yes, I just scanned contributing quickly and ran only ./gradlew -p buildSrc format.

@michael-simons
Copy link
Contributor Author

That failed with no apparent connection for me towards my changes…

@wilkinsona
Copy link
Member

Sorry about that. GitHub Actions and Pulsar don't seem to get on. We're not sure why yet. It might be resource constraints on the runner in which case #37578 should help.

@michael-simons
Copy link
Contributor Author

I removed the additional tests in favour to have it in the smoke tests project where it makes a lot more sense spring-projects/spring-aot-smoke-tests#190

Thanks for pointing me there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managed types for Neo4j are not used in Neo4j Data auto configuration.
3 participants