New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed types for Neo4j are not used in Neo4j Data auto configuration #37574
Conversation
Neo4jManagedTypes
to populate the mapping context.
https://github.com/spring-projects/spring-aot-smoke-tests would be a good place for the new test. Having looked there just now, I've noticed that we don't have any coverage for SDN. Setting up a new project in the smoke tests is a little bit involved so we can take a look at that and copy over something that's equivalent to the test proposed here. |
Hu… I'm quite sure I did run the format check (and check style afterwards…) 👀 Edit: Aaah yes, I just scanned contributing quickly and ran only |
That failed with no apparent connection for me towards my changes… |
Sorry about that. GitHub Actions and Pulsar don't seem to get on. We're not sure why yet. It might be resource constraints on the runner in which case #37578 should help. |
87eb37d
to
f9222d3
Compare
I removed the additional tests in favour to have it in the smoke tests project where it makes a lot more sense spring-projects/spring-aot-smoke-tests#190 Thanks for pointing me there. |
This fixes #37573.
I tested the fix locally in native image mode and added a test that reliable fails without using
Neo4jManagedTypes
proper.I don't know whether you run the integration tests in native mode, or put them somewhere else. If the latter is the case, please point me where I can move this or feel free to move it around yourself.
I suggest back porting this to 3.1 and 3.0 (I think 3.0 already managed SDN 7, including the dedicated managed types).
Thanks a lot!