Add Artemis Service Connection for Docker Compose and Testcontainers #39311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eddumelendez
commented
Jan 25, 2024
•
eddumelendez
commented
- Update Testcontainers version to 1.19.4
- Add service connection for Testcontainers Artemis (available in version 1.19.4)
- Add service connection for Docker Compose Artemis
spring-projects-issues
added
the
status: waiting-for-triage
|
It fails because of the change in commons-compress. See diff apache/commons-compress@rel/commons-compress-1.24.0...rel/commons-compress-1.25.0#diff-19b93108b5b4d5b1f4826b7dce61b416beb5a02d928ae8868412d971601ab201R568. Current common-compress version in spring-boot-parent is 1.23.0. Testcontainers 1.19.3 uses commons-compress 1.23.0 and Testcontainers 1.19.4 uses commons-compress version 1.25.0. I noticed the change when submitting this PR. |
darkmastermindz
added a commit
to darkmastermindz/spring-boot
that referenced
this pull request
Jan 26, 2024
darkmastermindz
added a commit
to darkmastermindz/spring-boot
that referenced
this pull request
Jan 26, 2024
mhalbritter
pushed a commit
to mhalbritter/spring-boot
that referenced
this pull request
Jan 30, 2024
mhalbritter
added a commit
to mhalbritter/spring-boot
that referenced
this pull request
Jan 30, 2024
|
I have rebased the PR on top of main and have some polishing changes in this branch: https://github.com/mhalbritter/spring-boot/tree/pr/39311 This fixes the docker compose integration, too. I'd like to do the Testcontainers version update in a separate issue, however. |
mhalbritter
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
Jan 31, 2024
mhalbritter
added a commit
that referenced
this pull request
Jan 31, 2024
|
Thanks a lot, Eddú! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.