Add customizer callback for WebHttpHandlerBuilder #39467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
scottfrederick
added
type: enhancement
wilkinsona
requested changes
Feb 8, 2024
There was a problem hiding this comment.
Thanks very much for the PR, @BenchmarkingBuffalo.
In addition to my comment about ordering, it would be good to mention the new callback very briefly in the reference docs, perhaps in this section. The source for that section can be found here.
...n/java/org/springframework/boot/autoconfigure/web/reactive/HttpHandlerAutoConfiguration.java
Outdated
Show resolved
Hide resolved
Add a new interface for customizing the WebHttpHandlerBuilder before the HttpHandler is built from it. See spring-projectsgh-39324
BenchmarkingBuffalo
force-pushed
the
39324-webhttphandlerbuilder-customizer-callback
branch
from
85b7761
to
4a27d60
Compare
scottfrederick
pushed a commit
that referenced
this pull request
Feb 8, 2024
Add a new interface for customizing the WebHttpHandlerBuilder before the HttpHandler is built from it. See gh-39467
|
Thanks for another great contribution @BenchmarkingBuffalo! |
BenchmarkingBuffalo
deleted the
39324-webhttphandlerbuilder-customizer-callback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new interface for customizing the WebHttpHandlerBuilder before the HttpHandler is built from it.
For the test, there is also the alternative to use a customizer adding a filter and then take AssertJ and some InstanceOf checks to see, if the filter was added to the chain.
It works as well, but seemed a bit long in code to me.
If you think, this is a better test, hit me up and I will change it.
See gh-39324