Banner printing doesn't respect set charset #39601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alvican Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@alvican Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mhalbritter
changed the title
mhalbritter
added
type: bug
mhalbritter
pushed a commit
that referenced
this pull request
Feb 19, 2024
mhalbritter
added a commit
that referenced
this pull request
Feb 19, 2024
|
Thank you very much and congratulations on your first contribution 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the printing of the banner in log mode (
spring.main.banner-mode="log") only works correctly (correctly = displays unicode characters the correct way, without surrogate glyphs)if
spring.banner.charsetmatchesfile.encoding.The banner is read using the encoding specified by
spring.banner.charset, before it is written in a local dependent way (dependent onfile.encoding) into theByteArrayOutputStream. After that it is re-read using theoriginal
spring.banner.charset. This leads to unwanted replacements.Proposed Solution -> Write banner into
ByteArrayOutputStreamusing the original encoding and not the local dependent encoding.Affected method:
createStringFromBanner(Banner banner, Environment environment, Class<?> mainApplicationClass)Local dependent writing by using
PrintStreamconstructor with single argument (no encoding specified)banner.printBanner(environment, mainApplicationClass, new PrintStream(baos));