Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve nested placeholders as possible if value is CharSequence #40862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Resolve nested placeholders as possible if value is CharSequence #40862

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented May 22, 2024

Fix GH-34195

@quaff quaff mentioned this pull request May 22, 2024
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 22, 2024
@mhalbritter mhalbritter changed the title Resolve nested placeholders if value is CharSequence Allow values from configtree to resolve nested placeholders May 22, 2024
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 22, 2024
@mhalbritter mhalbritter added this to the 3.4.x milestone May 22, 2024
@quaff
Copy link
Contributor Author

quaff commented May 31, 2024

Please note the argument at Spring Framework side.

@quaff quaff force-pushed the patch-63 branch 2 times, most recently from 424809a to e8db492 Compare May 31, 2024 03:08
@quaff quaff changed the title Allow values from configtree to resolve nested placeholders Resolve nested placeholders as possible if value is CharSequence May 31, 2024
@quaff
Copy link
Contributor Author

quaff commented May 31, 2024 •
edited
Loading

Please note the argument at Spring Framework side.

Resolved by not resolving nested placeholders if value is instance of targetValueType.

@quaff quaff mentioned this pull request May 31, 2024
Closed
@philwebb philwebb changed the title Resolve nested placeholders as possible if value is CharSequence Resolve nested placeholders as possible if value is CharSequence Jun 11, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.5.x Jun 17, 2024
@philwebb philwebb self-requested a review June 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philwebb philwebb Awaiting requested review from philwebb

Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.

Allow values from configtree to resolve nested placeholders
4 participants
@quaff @philwebb @spring-projects-issues @mhalbritter