-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Server Starter for Spring Boot #5206
Conversation
22943dc
to
1564766
Compare
As listed here there's already a third-party starter for gRPC. I don't think that we want to duplicate that effort with a first-party starter as well. If there is functionality in this PR that's not supported by the existing starter, perhaps this PR could be reworked as an enhancement to the existing third-party project? |
Hiya - I developed this independently from the other. Let me see how we can combine forces. There are a couple of minor differences, but the major one is that if we can get plugin preconfigured in the parent POM, the getting started experience is very awesome. Finally, it'll also be great to get on start.spring.io. Secondly, this is focused on the server side. The client side can be a different autoconfigurer. And in most cases, we don't want to start the server if we are only a client. Thanks! |
I'll close this one for now and we'll see how the efforts go over on LogNet/grpc-spring-boot-starter#1. It probably makes sense to develop things there a little more before we consider adding a starter directly to Boot. |
Hello Phil |
IMO, it's not just additional features or test scenarios that we'd like to wait for. It's also seeing if the functionality is used by a broad set of Boot users as we need to be careful not to spread the core Boot team's focus too thinly. |
I got your point, thanks. |
Hi all,
This is my first stab at creating a starter for Spring Boot. This is the first set, which configures and starts a gRPC server, and also discovers gRPC service implementations.