Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC Server Starter for Spring Boot #5206

Closed
wants to merge 1 commit into from

Conversation

saturnism
Copy link

Hi all,

This is my first stab at creating a starter for Spring Boot. This is the first set, which configures and starts a gRPC server, and also discovers gRPC service implementations.

@wilkinsona
Copy link
Member

As listed here there's already a third-party starter for gRPC. I don't think that we want to duplicate that effort with a first-party starter as well. If there is functionality in this PR that's not supported by the existing starter, perhaps this PR could be reworked as an enhancement to the existing third-party project?

@saturnism saturnism changed the title gRPC Starter for Spring Boot gRPC Server Starter for Spring Boot Feb 25, 2016
@saturnism
Copy link
Author

Hiya - I developed this independently from the other. Let me see how we can combine forces.

There are a couple of minor differences, but the major one is that if we can get plugin preconfigured in the parent POM, the getting started experience is very awesome. Finally, it'll also be great to get on start.spring.io.

Secondly, this is focused on the server side. The client side can be a different autoconfigurer. And in most cases, we don't want to start the server if we are only a client.

Thanks!

@philwebb
Copy link
Member

I'll close this one for now and we'll see how the efforts go over on LogNet/grpc-spring-boot-starter#1. It probably makes sense to develop things there a little more before we consider adding a starter directly to Boot.

@philwebb philwebb closed this Feb 25, 2016
@philwebb philwebb added status: on-hold We can't start working on this issue yet and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 25, 2016
@jvmlet
Copy link
Contributor

jvmlet commented Mar 6, 2016

Hello Phil
I'm the author of LogNet/grpc-spring-boot-starter.
What additional features/test scenarios do you want to see in this starter in order to include it to Boot ?
Thanks

@wilkinsona
Copy link
Member

IMO, it's not just additional features or test scenarios that we'd like to wait for. It's also seeing if the functionality is used by a broad set of Boot users as we need to be careful not to spread the core Boot team's focus too thinly.

@jvmlet
Copy link
Contributor

jvmlet commented Mar 7, 2016

I got your point, thanks.

@snicoll snicoll removed the status: on-hold We can't start working on this issue yet label Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants