Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Spring Data release train BOM instead of individual modules. #660

Closed
wants to merge 1 commit into from

Conversation

odrotbohm
Copy link
Member

The dependencies pom.xml now declares an import to the spring-data-releasetrain BOM pom.xml which in turn constraints version numbers for a dedicated release train release. This has the effect of users being able to upgrade to a certain release train by redeclaring the spring-data-releasetrain.version property to e.g. Dijkstra-M1. Individual modules can be upgraded by simply declaring the dependency in the desired version manually in a or block.

We'll have to wait for the application of this change until Codd SR2 is released as previously released versions unfortunately declare an invalid Spring Data REST artifact identifier (which would leave boot bit a broken starter pom for the data REST module).

Removed the explicit declaration for Spring HATEOAS as it is pulled in transitively by Spring Data REST anyway and thus makes sure it's in a compatible version.

TODOs:

  • wait for Codd SR2 to be released before applying the patch (ETA April, 15th)
  • move to Codd-SR2 as version number for the release train property
  • drop snapshot repository declaration

/cc @wilkinsona

The dependencies pom.xml now declares an import to the spring-data-releasetrain BOM pom.xml which in turn constraints version numbers for a dedicated release train release. This has the effect of users being able to upgrade to a certain release train by redeclaring the spring-data-releasetrain.version property to e.g. Dijkstra-M1. Individual modules can be upgraded by simply declaring the dependency in the desired version manually in a <dependencies /> or <dependencyManagement /> block.

Removed the explicit declaration for Spring HATEOAS as it is pulled in transitively by Spring Data REST anyway and thus makes sure it's in a compatible version.
@odrotbohm
Copy link
Member Author

Spring Data Codd SR2 was just released and I've updated the PR accordingly.

@philwebb philwebb added this to the 1.1.0 milestone Apr 22, 2014
@wilkinsona
Copy link
Member

@olivergierke, given that this is targeted at Boot 1.1, I think it might make sense to go straight to the Dijkstra release train. We could consume the already-released M1 for the time being, and then pick up the RC(s) and RELEASE as they become available.

@odrotbohm
Copy link
Member Author

We can certainly wait for that and then update the PR accordingly. I just thought I make it mergeable as soon as possible as Boot released on Codd already and bugfix releases might want to upgrade to newer bugfix releases of Codd as well.

@wilkinsona
Copy link
Member

Understood. Perhaps we need to do two things: update 1.0.x (1.0.3 most likely as Phil's planning to release 1.0.2 this morning) to use Codd SR2 and update 1.1.0 to use Dijkstra?

@odrotbohm
Copy link
Member Author

Sounds good to me. /cc @philwebb FYI

@philwebb
Copy link
Member

I've bumped Spring Boot 1.0.2 to use Codd SR2 but I'm going to leave the BOM out of the 1.0.x lines. We'll merge this into master when it jumps to 1.1.x.

@dsyer
Copy link
Member

dsyer commented Apr 25, 2014

Merged in commit 26c5a3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants