Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new-branch script #184

Closed
gregturn opened this issue Jul 7, 2015 · 1 comment
Closed

Fix new-branch script #184

gregturn opened this issue Jul 7, 2015 · 1 comment
Assignees
@odrotbohm
Milestone
1.8 M1 (Hopper)

Comments

@gregturn
Copy link
Contributor

gregturn commented Jul 7, 2015

The script leans on offline mode, and that doesn't always work well. It would also be beneficial to remove the ".sh" suffix, so it doesn't HAVE to remain a shell script in the future.
gregturn added a commit to gregturn/spring-data-build that referenced this issue Jul 7, 2015
@gregturn
spring-projects#184 - Fix new-branch script
390ab99 
* Set it up to work NOT in offline mode
* Rename it to drop the .sh suffix. That way, we can change its language in the future without user having to know.
gregturn added a commit that referenced this issue Oct 5, 2015
@gregturn @odrotbohm
#184 - Improvements to new issue branch script
a68134a 
Removed the offline mode for the issue branch. If dependencies are missing it won't work offline either. Rename it to drop the .sh suffix. That way, we can change its language in the future without user having to know.

Original pull request: #185.
@odrotbohm
Copy link
Member

See #185.

@odrotbohm odrotbohm added this to the 1.8 M1 (Hopper) milestone Oct 5, 2015
@odrotbohm odrotbohm self-assigned this Oct 5, 2015
gregturn added a commit that referenced this issue Oct 5, 2015
@gregturn @odrotbohm
#184 - Improvements to new issue branch script
04ac2a7 
Removed the offline mode for the issue branch. If dependencies are missing it won't work offline either. Rename it to drop the .sh suffix. That way, we can change its language in the future without user having to know.

Original pull request: #185.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
None yet
Projects
None yet
Milestone
1.8 M1 (Hopper)
Development

No branches or pull requests
2 participants
@odrotbohm @gregturn