Skip to content

/ spring-data-commons

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve method signature of RepositoryInvoker.invokeQueryMethod(…) [DATACMNS-678] #1145

Closed
spring-projects-issues opened this issue Apr 7, 2015 · 0 comments
Closed

Improve method signature of RepositoryInvoker.invokeQueryMethod(…) [DATACMNS-678] #1145

spring-projects-issues opened this issue Apr 7, 2015 · 0 comments
Assignees
@odrotbohm
Labels
in: repository in: web type: enhancement
Milestone
1.11 M1 (Gosling)

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Apr 7, 2015

Oliver Drotbohm opened DATACMNS-678 and commented

Currently RepositoryInvoker.invokeQueryMethod(…) strongly assumes the values for the query method parameters are always String instances. This however eventually only allows Converter instances to kick in that convert from String to the actual parameter type.

We should loosen that contract to generally accept Object instances so that clients can tweak incoming parameters into special types that can then be treated in a special way by registering the corresponding converters

Affects: 1.10 GA (Fowler)

Issue Links:

  • DATAREST-502 Not convenient to search a repository by a related entity using links
    ("is depended on by")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: repository in: web type: enhancement
Projects
None yet
Milestone
1.11 M1 (Gosling)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@odrotbohm @spring-projects-issues
You can’t perform that action at this time.