Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify javadoc for PageableHandlerMethodArgumentResolverSupport#setFallbackPageable #2551

Closed
hgjd opened this issue Feb 16, 2022 · 1 comment

Comments

@hgjd
Copy link

hgjd commented Feb 16, 2022

The javadoc for the setFallbackPageable method of PageableHandlerMethodArgumentResolverSupport is unclear in two places.

  1. in case no {@link PageableDefault} or {@link PageableDefault} (the latter only supported in legacy mode)
    Both options are the same.
  2. If you set this to {@literal Optional#empty()} The method only accepts a non-null Pageable, so it is unclear how to set this to Optional.empty().

Unfortunately I can't propose a fix, because it is not obvious to me what the originally intended message was.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 16, 2022
@mp911de
Copy link
Member

mp911de commented Feb 17, 2022

PageableDefaults was already removed with Spring Data 1.8. We also introduced Pageable.unpaged() with Spring Data 2.0 so the documentation doesn't sense anymore. Let me rewrite the documentation.

@mp911de mp911de added in: documentation and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 17, 2022
@mp911de mp911de self-assigned this Feb 17, 2022
@mp911de mp911de changed the title Clarify javadoc for PageableHandlerMethodArgumentResolverSupport#setFallbackPageable Clarify javadoc for PageableHandlerMethodArgumentResolverSupport#setFallbackPageable Feb 17, 2022
@mp911de mp911de added this to the 2.5.9 (2021.0.9) milestone Feb 17, 2022
mp911de added a commit that referenced this issue Feb 17, 2022
mp911de added a commit that referenced this issue Feb 17, 2022
mp911de added a commit that referenced this issue Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants