DATACMNS-1376 - Fix illegal access warning in DefaultMethodInvokingMethodInterceptor on Java 9 and higher #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AuditingHandler. Internal refactorings to expose the auditor types to use for creator and modifier. Tweaked implementation to be generally able to deal with multiple AuditorAware beans. AuditingHandler now dynamically looks up AuditorAware implementations from a BeanFactory in case no unique AuditorAware instance has been configured.
…thodInterceptor on Java 9 and higher. We now attempt to use private MethodHandles lookup as the first mechanism to resolve a MethodHandle for default interface methods and fall back to reflection-based Lookup construction if private lookup is not available. Reflective availability is checked lazily to prevent illegal access on enum constant construction. This approach prevents an illegal access which was logged by attempting a reflection-based lookup first. We also introduced a FALLBACK mechanism to split encapsulated access from a fallback mechanism.
odrotbohm
pushed a commit
that referenced
this pull request
Aug 17, 2018
…thodInterceptor on Java 9 and higher. We now attempt to use private MethodHandles lookup as the first mechanism to resolve a MethodHandle for default interface methods and fall back to reflection-based Lookup construction if private lookup is not available. Reflective availability is checked lazily to prevent illegal access on enum constant construction. This approach prevents an illegal access which was logged by attempting a reflection-based lookup first. We also introduced a FALLBACK mechanism to split encapsulated access from a fallback mechanism. Original pull request: #307.
odrotbohm
added a commit
that referenced
this pull request
Aug 17, 2018
Moved JVM version lookup into Version. Original pull request: #307.
odrotbohm
pushed a commit
that referenced
this pull request
Aug 17, 2018
…thodInterceptor on Java 9 and higher. We now attempt to use private MethodHandles lookup as the first mechanism to resolve a MethodHandle for default interface methods and fall back to reflection-based Lookup construction if private lookup is not available. Reflective availability is checked lazily to prevent illegal access on enum constant construction. This approach prevents an illegal access which was logged by attempting a reflection-based lookup first. We also introduced a FALLBACK mechanism to split encapsulated access from a fallback mechanism. Original pull request: #307.
odrotbohm
added a commit
that referenced
this pull request
Aug 17, 2018
Moved JVM version lookup into Version. Original pull request: #307.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now attempt to use private
MethodHandleslookup as the first mechanism to resolve a MethodHandle for default interface methods and fall back to reflection-based Lookup construction if private lookup is not available. Reflective availability is checked lazily to prevent illegal access on enum constant construction. This approach prevents an illegal access which was logged by attempting a reflection-based lookup first.We also introduced a
FALLBACKmechanism to split encapsulated access from a fallback mechanism.Related ticket: DATACMNS-1376.