Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field without the equals and hashCode contracts. #2858

Closed
youssef3wi opened this issue Feb 26, 2024 · 0 comments · Fixed by #2859
Closed

Field without the equals and hashCode contracts. #2858

youssef3wi opened this issue Feb 26, 2024 · 0 comments · Fixed by #2859
Labels
status: waiting-for-triage An issue we've not yet triaged

Comments

@youssef3wi
Copy link
Contributor

The Criteria equals check if fields have the same instance in memory without using the equals method.

spring-data-elasticsearch/src/main/java/org/springframework/data/elasticsearch/core/query/Criteria.java

Line 846 in 96185f9

if (!Objects.equals(field, criteria.field))

This can cause errors during testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement the equals and hashCode contracts for Field. youssef3wi/spring-data-elasticsearch
2 participants
@spring-projects-issues @youssef3wi