Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAES-285 - Support for Elasticsearch 5.0 #162

Closed
wants to merge 2 commits into from

Conversation

withccm
Copy link

@withccm withccm commented Dec 3, 2016

Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
Make sure that:

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).
  • You provide your full name and an email address registered with your GitHub account. If you’re a first-time submitter, make sure you have completed the Contributor’s License Agreement form.

Hello.
I worked to support the latest version. https://jira.spring.io/browse/DATAES-285
I'm afraid, I did not formatting. If you need formatting, I'll try again.

I met a few issues.

  • No suggest support.

  • No suggest facet.
    Facets have been replaced by aggregations in Elasticsearch 1.0, which
    are a superset of facets.

  • SoredFields is not working in Elasticsearch 5.x,
    I guess it's an Elasticsearch bug.

  • The string field type will continue to work during the 5.x series.

  • Filed.String -> Filed.Text

  • Painless, Groovy Plugins not added.

I hope that I will be a little help.

withccm and others added 2 commits December 3, 2016 15:28
No suggest support.

No suggest facet. 
Facets have been replaced by aggregations in Elasticsearch 1.0, which
are a superset of facets.

SoredFields is not working in Elasticsearch 5.x, 
I guess it's an Elasticsearch bug.

The string field type will continue to work during the 5.x series.
* Filed.String -> Filed.Text

Painless, Groovy Plugins not added.
@otrosien
Copy link

Two things: First, it would be really nice if the reformatting would be kept out of this PR. It is a lot of noise and makes it a lot harder to rebase and merge into the code base. Second, we would be willing to experiment and contribute to this feature, if there was a snapshot build off the feature branch in the spring snapshots-repository. Is that possible?

@withccm
Copy link
Author

withccm commented Jan 18, 2017

Of course. I will try as soon as possible.

@withccm
Copy link
Author

withccm commented Jan 18, 2017

Sorry. Formatting is not working well by Eclipse, I closed this PR.
I open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants