Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.2. Annotation Configuration Support, refers to incorrect Indexing annotations [DATAGEODE-157] #205

Closed
spring-projects-issues opened this issue Nov 27, 2018 · 1 comment
Assignees
Labels
in: documentation Issues in documentation status: invalid An issue that we don't feel is valid

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Nov 27, 2018

kohlmu-pivotal opened DATAGEODE-157 and commented


Affects: 2.0.12 (Kay SR12), 2.1.3 (Lovelace SR3), 2.2 M1 (Moore)

Backported to: 2.1.4 (Lovelace SR4), 2.0.13 (Kay SR13)

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Dec 13, 2018

John Blum commented

kohlmu-pivotal - Since you did not add a description to this improvement, I have no idea what problem you are specifically referring to in the SDG Reference Documentation, Session 13.2 - Annotation Configuration Support for Lucene Indexes.

In fact, the example code shown deliberately shows a combination of an OQL Index, on a Person's birthDate, along with Lucene Index on the Person's lastName.

@PartitionRegion("People")
class Person {

    Gender gender;

    @Index
    LocalDate birthDate;

    String firstName;

    @LuceneIndex;
    String lastName;

    ...
}

The documentation then goes on to describe how to enable this functionality, using both @EnableEntityDefinedRegions and @EnableIndexing.

@PeerCacheApplication
@EnableEntityDefinedRegions(..)
@EnableIndexing
class GeodeConfiguration { .. }

The @PartitionRegion mapping annotation was used on the Person entity class to reinforce the point that the Apache Geode cache Region on which the Lucene Index will be added must be a PARTITION Region.

There does not appear to be a problem in the documentation AFAICT.

Please reopen this JIRA ticket if I missed something.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: documentation Issues in documentation status: invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants