Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAJDBC-555 - Document supported databases #225

Closed
wants to merge 4 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented May 28, 2020

Also, polishing and added standard-documentation bits.


Related ticket: DATAJDBC-555.

You can let Spring auto-discover your `Dialect` by registering a class that implements `org.springframework.data.jdbc.repository.config.DialectResolver$JdbcDialectProvider` through `META-INF/spring.factories`.
`DialectResolver` discovers dialect provider implementations from the class path using Spring's `SpringFactoriesLoader`.

If you use a database for which no dialect is available, then your application won’t startup. In that case, you’ll have to ask your vendor to provide a `Dialect` implementation. Alternatively, you can:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same as the previous paragraph?
I'd say we keep only one of them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we can remove the previous one as the information is duplicated.

schauder pushed a commit that referenced this pull request Jun 10, 2020
Fix formatting.

Original pull request: #225.
schauder pushed a commit that referenced this pull request Jun 10, 2020
schauder pushed a commit that referenced this pull request Jun 10, 2020
schauder added a commit that referenced this pull request Jun 10, 2020
Removed redundant content.
Change to active voice.
Formatting.

Original pull request: #225.
@schauder
Copy link
Contributor

This is polished and merged.

@schauder schauder closed this Jun 10, 2020
schauder pushed a commit that referenced this pull request Jun 10, 2020
Fix formatting.

Original pull request: #225.
schauder pushed a commit that referenced this pull request Jun 10, 2020
schauder pushed a commit that referenced this pull request Jun 10, 2020
schauder added a commit that referenced this pull request Jun 10, 2020
Removed redundant content.
Change to active voice.
Formatting.

Original pull request: #225.
@schauder schauder deleted the issue/DATAJDBC-555 branch May 26, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants