Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction-manager-ref namespace attribute not propagated into bean configuration [DATAJPA-15] #453

Closed
spring-projects-issues opened this issue Jan 25, 2011 · 6 comments
Assignees
Labels
in: core Issues in core support type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link

Rain Wang opened DATAJPA-15 and commented

My App has a transactionMangername that is not a "transactionManager" name, I had set the the attribute of the entity-manager-factory-ref, but the app still scan the "tranactionManager"


Attachments:

Issue Links:

  • DATACMNS-12 Make usage of transactions optional for repositories
    ("depends on")

Referenced from: commits b884e73

1 votes, 1 watchers

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

entity-manager-factory-ref is (as the name suggests) to point the EntityManagerFactory bean to be used to obtain an EntityManager from. To point the repositories to use a transaction manager named other than transactionManager use the transaction-manager-ref attribute. Make sure your transaction manager uses the same EntityManagerFactory that you hand to the repositories element

@spring-projects-issues
Copy link
Author

jokeway commented

hi,Oliver Gierke
I think the bug title should be changed to:
Why do not the attribute of the transaction-manager-ref be valid?
The method postProcessBeanDefinition had nothing to do with transaction-manager-ref config.

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

Sorry, I don't get you at all. What's wrong with transaction-manager-ref? Lowering the severity until we actually now what's wrong

@spring-projects-issues
Copy link
Author

jokeway commented

The code in 'hades' process the transaction-manager-ref :

beanDefinitionBuilder.addPropertyValue("transactionManager",
        context.getTransactionManagerRef());

Missing in 'spring-data'

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

Ah, I see. Well spotted, thanks for filing!

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

Should be fixed and available in the snapshot tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core support type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants