DATAMONGO-1127 - Add support for geoNear queries with distance information. #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasdarimont
force-pushed
the
issue/DATAMONGO-1127
branch
from
8eb0af1
to
517c216
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Dec 24, 2014
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations. Original pull request: #261.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1127
branch
from
517c216
to
bc27ca6
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Dec 29, 2014
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations. Original pull request: #261.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1127
branch
from
bc27ca6
to
505d15b
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Dec 29, 2014
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations. Original pull request: #261.
|
I don't quite like the addition of |
added 2 commits
January 20, 2015 13:09
…ation. Prepare issue branch.
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations. Original pull request: #261.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1127
branch
from
505d15b
to
ba9797d
Compare
thomasdarimont
pushed a commit
that referenced
this pull request
Jan 20, 2015
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Original pull request: #261.
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Original pull request: #261.
thomasdarimont
force-pushed
the
issue/DATAMONGO-1127
branch
from
ba9797d
to
00d3da7
Compare
| * @return | ||
| * @since 1.7 | ||
| */ | ||
| public static GeoNearOperation geoNear(NearQuery query, String distanceField) { |
There was a problem hiding this comment.
Should we actually add an overload without the distance field applied so that basically people can mimic what they got when using new GeoNearOperation(nearQuery) before?
There was a problem hiding this comment.
the geoNear(...) method was not exposed before this PR.
There was a problem hiding this comment.
I see that. Still, we need to keep the constructor in GeoNearOperations which then raises the question why geoNear(query, distance) is available as factory method but geoNear(query) is not. We should stay symmetric here.
…ation. Revised the code according to code review. Note that the $geoNear Operation within an Aggregation requires a distanceField to be configured, therefore we make sure that it is set accordingly. Added hints to use the static factory methods of Aggregation to the javadoc of the AggreationOperation classes.
thomasdarimont
pushed a commit
that referenced
this pull request
Jan 20, 2015
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations. Original pull request: #261.
thomasdarimont
pushed a commit
that referenced
this pull request
Jan 20, 2015
…ation. We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations. Original pull request: #261.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support geoNear queries in Aggregations. Exposed GeoNearOperation factory method in Aggregation. Introduced new distanceField property to NearQuery since it is required for geoNear queries in Aggregations.