DATAMONGO-1406 - Propagate PersistentEntity when mapping query criteria for nested keywords. #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rying nested fields in combination with nested keywords. Prepare issue branch.
…ia for nested keywords. Previously, query mapping of nested keywords combined with nested properties did not pass the PersistentEntity. That resulted in the usage of property names as field names instead of using configuration details of @field. The QueryMapper now propagates the PersistentEntity when mapping nested keywords. The criteria mapping chain for nested keywords and properties has now access to the PersistentEntity and can use configured field names.
christophstrobl
pushed a commit
that referenced
this pull request
Aug 25, 2016
…ia for nested keywords. We now propagate the PersistentEntity when mapping nested keywords so that the criteria mapping chain for nested keywords and properties has now access to the PersistentEntity and can use configured field names. Previously the plain property names have been used as field names and potential customizations via @field have been ignored. Original Pull Request: #384
christophstrobl
pushed a commit
that referenced
this pull request
Aug 25, 2016
…ia for nested keywords. We now propagate the PersistentEntity when mapping nested keywords so that the criteria mapping chain for nested keywords and properties has now access to the PersistentEntity and can use configured field names. Previously the plain property names have been used as field names and potential customizations via @field have been ignored. Original Pull Request: #384
christophstrobl
pushed a commit
that referenced
this pull request
Aug 25, 2016
…ia for nested keywords. We now propagate the PersistentEntity when mapping nested keywords so that the criteria mapping chain for nested keywords and properties has now access to the PersistentEntity and can use configured field names. Previously the plain property names have been used as field names and potential customizations via @field have been ignored. Original Pull Request: #384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, query mapping of nested keywords combined with nested properties did not pass the PersistentEntity. That resulted in the usage of property names as field names instead of using configuration details of
@Field.The QueryMapper now propagates the PersistentEntity when mapping nested keywords. The criteria mapping chain for nested keywords and properties has now access to the PersistentEntity and can use configured field names.
Related ticket: DATAMONGO-1406