Fix Querydsl conversion for properties with explicit target type. #4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure to convert values, for Querydsl predicates pointing to a property with an explicitly annotated target type, into the desired format.
mp911de
reviewed
Jun 14, 2023
| if (!isReference(path)) { | ||
| if(property != null && property.hasExplicitWriteTarget()) { |
There was a problem hiding this comment.
I wonder why this is necessary as the Querydsl predicate is rendered into our Query object that is then converted using the domain type information.
There was a problem hiding this comment.
true, the query mapper will take care of the conversion. So it works fine on current main, let me get back to the reporter to see if that's an issue with earlier versions. I would have argued that SpringDataMongodbSerializer should already consider this based on its description, so it's worth updating that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure to convert values, for Querydsl predicates pointing to a property with an explicitly annotated target type, into the desired format.
Resolves: #4359