DATAMONGO-1986 - Fix unmapped objects in aggregation pipeline. #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or TypedAggregation We now initialize a TypeBasedAggregationOperationContext for TypedAggregations no matter what. This makes sure that potential Criteria objects are run trough the QueryMapper. In case the default context is used we now also make sure to at least run the aggregation pipeline through the QueryMapper to avoid passing on non MongoDB simple types to the driver.
mp911de
pushed a commit
that referenced
this pull request
Jun 6, 2018
…or TypedAggregation. We now initialize a TypeBasedAggregationOperationContext for TypedAggregations if no context is provided. This makes sure that potential Criteria objects are run trough the QueryMapper. In case the default context is used we now also make sure to at least run the aggregation pipeline through the QueryMapper to avoid passing on non MongoDB simple types to the driver. Original pull request: #564.
mp911de
added a commit
that referenced
this pull request
Jun 6, 2018
Refactor duplicated code into AggregationUtil. Original pull request: #564.
mp911de
pushed a commit
that referenced
this pull request
Jun 6, 2018
…or TypedAggregation. We now initialize a TypeBasedAggregationOperationContext for TypedAggregations if no context is provided. This makes sure that potential Criteria objects are run trough the QueryMapper. In case the default context is used we now also make sure to at least run the aggregation pipeline through the QueryMapper to avoid passing on non MongoDB simple types to the driver. Original pull request: #564.
mp911de
added a commit
that referenced
this pull request
Jun 6, 2018
Refactor duplicated code into AggregationUtil. Original pull request: #564.
mp911de
pushed a commit
that referenced
this pull request
Jun 6, 2018
…or TypedAggregation. We now initialize a TypeBasedAggregationOperationContext for TypedAggregations if no context is provided. This makes sure that potential Criteria objects are run trough the QueryMapper. In case the default context is used we now also make sure to at least run the aggregation pipeline through the QueryMapper to avoid passing on non MongoDB simple types to the driver. Original pull request: #564.
mp911de
added a commit
that referenced
this pull request
Jun 6, 2018
Refactor duplicated code into AggregationUtil. Original pull request: #564.
|
That's merged, polished, and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now initialize a
TypeBasedAggregationOperationContextforTypedAggregations no matter what. This makes sure that potentialCriteriaobjects are run trough theQueryMapper.In case the default context is used we now also make sure to at least run the aggregation pipeline through the
QueryMapperto avoid passing on non MongoDB simple types to the drive