DATAMONGO-1311 - Configuration of query batchsize through Query.cursorBatchSize(…). #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rBatchSize(…). We now allow configuration of the find cursor/find publisher batch sizes using Query.cursorBatchSize(…). Configuring the batch size gives users more fine grained control over the fetch behavior especially in reactive usage scenarios as the batch size defaults in FindPublisher to the remaining demand. This can cause several roundtrips in cases the remaining demand is small and the emitted elements are dropped rapidly (e.g. using filter(…)). With the upgrade to a newer Reactive Streams driver, we can also apply the batch size to aggregation operations invoked through ReactiveMongoTemplate.aggregate(…).
christophstrobl
force-pushed
the
issue/DATAMONGO-1311
branch
from
5c05f2f
to
2bfc43e
Compare
Update Javadoc and alter batchSize default to zero. Along the lines remove deprecated driver method usage and add deprecations for options about the be removed in subsequent MongoDB server releases.
christophstrobl
force-pushed
the
issue/DATAMONGO-1311
branch
from
2bfc43e
to
73f301b
Compare
christophstrobl
pushed a commit
that referenced
this pull request
Jun 29, 2018
We now allow configuration of the find cursor/find publisher batch sizes using Query.cursorBatchSize(…). Configuring the batch size gives users more fine grained control over the fetch behavior especially in reactive usage scenarios as the batch size defaults in FindPublisher to the remaining demand. This can cause several roundtrips in cases the remaining demand is small and the emitted elements are dropped rapidly (e.g. using filter(…)). On the repository level @meta allows now configuration of the cursor batch size for derived finder methods. interface PersonRepository extends Repository<Person, Long> { @meta(cursorBatchSize = 100) Stream<Person> findAllByLastname(String lastname); } Original Pull Request: #575
christophstrobl
added a commit
that referenced
this pull request
Jun 29, 2018
Update Javadoc and add reference documentation. Alter @meta batchSize default to zero, as negative values bear a special meaning. Along the lines remove deprecated driver method usage and add deprecations for options about the be removed in subsequent MongoDB server releases. Original Pull Request: #575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow configuration of the find cursor/find publisher batch sizes using
Query.cursorBatchSize(…). Configuring the batch size gives users more fine-grained control over the fetch behavior especially in reactive usage scenarios as the batch size defaults inFindPublisherto the remaining demand. This can cause several roundtrips in cases the remaining demand is small and the emitted elements are dropped rapidly (e.g. using afilter(…)operator).With the upgrade to a newer Reactive Streams driver, we can also apply the batch size to aggregation operations invoked through
ReactiveMongoTemplate.aggregate(…).Related ticket: DATAMONGO-1311.