DATAGRAPH-1109 - Add support for persistence constructors for @QueryResults #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MappingContext has to be passed on, starting from the Neo4jRepositoryFactoryBean to the Neo4jRepositoryFactory and eventually to the GraphQueryMethod. The GraphRepositoryQuery than uses it for creating the CustomResultConverter. The OgmReflectionEntityInstantiator has been renamed and repurposed to a general QueryResultInstantiator which uses the OgmEntityInstantiator adapter if possible, otherwise the existing reflection based instantiator.
michael-simons
force-pushed
the
issue/DATAGRAPH-1109
branch
from
fe1d88f
to
50316b3
Compare
michael-simons
force-pushed
the
issue/DATAGRAPH-1109
branch
from
50316b3
to
e72ab23
Compare
|
Merged with commit aa9ba9e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support persistence constructors for classes annotated as
@NodeEntitybut not for projections based on DTOS annotated with@QueryResult.This PR provides persistence constructors for those projections as well, reducing the amount of different programming models a user has to deal with.
The PR is centered around the idea to make
OgmEntityInstantiatorAdaptera public api asNeo4jOgmEntityInstantiatorAdapterin the conversion package much as similar concepts in the Mongo store. It also drops the idea ofOgmReflectionEntityInstantiatorbeing solely an indirection against OGMs 3.1ReflectionEntityInstantiator. The guard whether the later is available is still applied (inCustomResultConverter).OgmReflectionEntityInstantiatorbecomesQueryResultInstantiatoras dedicated means of instantiating DTOs from a custom result. It either uses theReflectionEntityInstantiatoras before or the new public apiNeo4jOgmEntityInstantiatorAdapterif applicable.It is applicable if it get hold of the
Neo4jMappingContext.To pass this around, the
Neo4jRepositoryFactoryBeanandNeo4jRepositoryFactoryhave been extended to transport it up to theGraphQueryMethod, again, much as the Mongo store does.From there on it's accessible in all query related scenarios.