Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Spring Data R2DBC on top of Spring R2DBC #368

Closed
mp911de opened this issue May 15, 2020 · 0 comments
Closed

Refactor Spring Data R2DBC on top of Spring R2DBC #368

mp911de opened this issue May 15, 2020 · 0 comments
Labels
type: task A general task
Milestone
1.2 M1 (2020.0.0)

Comments

@mp911de
Copy link
Member

mp911de commented May 15, 2020

Spring Framework aims to include foundational R2DBC support in a similar way to Spring JDBC. We should adopt to these changes by deprecating org.springframework.data.r2dbc.core.DatabaseClient in favor of org.springframework.r2dbc.core.DatabaseClient.

Components on top of DatabaseClient should be rewritten to use Spring Framework's R2DBC variants. In particular:

  • Deprecate our DatabaseClient and all necessary infrastructure classes/interfaces
  • Deprecate ColumnMapRowMapper and SettableValue
  • Adapt AbstractR2dbcConfiguration
  • Deprecate connectionfactory package in favor of org.springframework.r2dbc.connectionfactory
  • Deprecate support package in favor of org.springframework.r2dbc.connectionfactory
  • Use Framework's DatabaseClient in R2dbcEntityTemplate and the repository support classes
@mp911de mp911de added the type: task A general task label May 15, 2020
@mp911de mp911de added this to the 1.2 M1 (2020.0.0) milestone May 15, 2020
@mp911de mp911de mentioned this issue Jul 14, 2020
Closed
mp911de added a commit that referenced this issue Jul 20, 2020
@mp911de
#368 - Prepare issue branch.
9542b64
mp911de added a commit that referenced this issue Jul 23, 2020
@mp911de
#368 - Prepare issue branch.
2cb8de6
mp911de added a commit that referenced this issue Jul 23, 2020
@mp911de
#368 - Deprecate API provided by Spring R2DBC.
9c1ca3b 
This commit deprecates API that has been moved to Spring R2DBC.
mp911de added a commit that referenced this issue Jul 23, 2020
@mp911de
#368 - Use Spring R2DBC.
7707b4f 
We now use Spring R2DBC DatabaseClient and utilities to implement Spring Data R2DBC functionality.
@mp911de mp911de mentioned this issue Jul 23, 2020
Closed
schauder added a commit that referenced this issue Jul 24, 2020
@schauder
#368 - Polishing.
b915038 
Line breaks after dots in ascii doctor file for easier reading of the source files.
Adds specific deprecation links instead of just links to the general package.
Removes an unused private method in `ConnectionFactoryUtils`
mp911de added a commit that referenced this issue Jul 28, 2020
@mp911de
#368 - Prepare issue branch.
5a70a01
mp911de added a commit that referenced this issue Jul 28, 2020
@mp911de
#368 - Deprecate API provided by Spring R2DBC.
5c4eee3 
This commit deprecates API that has been moved to Spring R2DBC.
mp911de added a commit that referenced this issue Jul 28, 2020
@mp911de
#368 - Use Spring R2DBC.
0fab99f 
We now use Spring R2DBC DatabaseClient and utilities to implement Spring Data R2DBC functionality.
mp911de added a commit that referenced this issue Jul 28, 2020
@mp911de
#368 - Polishing.
b18bdf0
@snicoll snicoll mentioned this issue Aug 3, 2020
Closed
This was referenced Aug 4, 2020
Closed
Closed
Closed
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#368 - Deprecate API provided by Spring R2DBC.
f331572 
This commit deprecates API that has been moved to Spring R2DBC.

Original pull request: #412.
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#368 - Use Spring R2DBC.
086c5a1 
We now use Spring R2DBC DatabaseClient and utilities to implement Spring Data R2DBC functionality.

Original pull request: #412.
mp911de added a commit that referenced this issue Aug 4, 2020
@mp911de
#368 - Polishing.
3d59c63 
Original pull request: #412.
mp911de pushed a commit that referenced this issue Aug 4, 2020
@schauder @mp911de
#368 - Polishing.
b0e03ea 
Line breaks after dots in ascii doctor file for easier reading of the source files.
Adds specific deprecation links instead of just links to the general package.
Removes an unused private method in `ConnectionFactoryUtils`

Original pull request: #412.
@mp911de mp911de closed this as completed Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
1.2 M1 (2020.0.0)
Development

No branches or pull requests
1 participant
@mp911de