Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit option to ScanCursor #2014

Closed
wants to merge 6 commits into from
Closed

Add limit option to ScanCursor #2014

wants to merge 6 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented Mar 23, 2021

Also, let Cursor extend CloseableIterator and deprecate Cursor.open (for removal from the public Cursor API).

Closes #1575

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 23, 2021
mp911de and others added 6 commits March 25, 2021 09:32
@mp911de @christophstrobl
Prepare issue branch.
2924330
@mp911de @christophstrobl
Add limit option to ScanCursor.
ad0aa4a 
ScanCursor can be now limited to a maximum number of elements to be retrieved.

Closes #1575
@mp911de @christophstrobl
Polishing.
917a3b2 
Let Cursor extend CloseableCursor. Refine nullability annotations and align nullability behavior in tests with actual nullability usage.
@mp911de @christophstrobl
Deprecate Cursor.open().
315fbd7 
This method should not be called from code consuming the Cursor.
@christophstrobl
Introduce ScanCursor limitation check method to.
ceba810 
This commit moves the limit field to the delegating sub class. This way it is possible to override the newly introduced limitReached(long) method without polluting the ScanCursor implementation with the limit check itself.
@christophstrobl
Remove limit(long) from cursor and hint users to stream().limit(...)
c1e0599
christophstrobl pushed a commit that referenced this pull request Mar 25, 2021
@mp911de @christophstrobl
Add limit option to ScanCursor.
b7f2d68 
ScanCursor can be now limited to a maximum number of elements to be retrieved.

Closes: #1575
Original Pull Request: #2014
christophstrobl pushed a commit that referenced this pull request Mar 25, 2021
@mp911de @christophstrobl
Polishing.
0061d6c 
Let Cursor extend CloseableCursor. Refine nullability annotations and align nullability behavior in tests with actual nullability usage.

See: #1575
Original Pull Request: #2014
christophstrobl pushed a commit that referenced this pull request Mar 25, 2021
@mp911de @christophstrobl
Deprecate Cursor.open().
b0dd3cd 
This method should not be called from code consuming the Cursor.

See: #1575
Original Pull Request: #2014
christophstrobl added a commit that referenced this pull request Mar 25, 2021
@christophstrobl
Remove limit(long) from Cursor and hint users to stream().limit(...)
3a1fbe1 
Original Pull Request: #2014
@christophstrobl christophstrobl deleted the issue/1575 branch March 25, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christophstrobl christophstrobl

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add limit option to ScanCursor. [DATAREDIS-1004]
3 participants
@mp911de @christophstrobl @spring-projects-issues