Skip to content

Commit

Permalink
Polishing.
Browse files Browse the repository at this point in the history
Added Javadoc, removed superfluous code.

Original pull request #980
  • Loading branch information
schauder committed May 18, 2021
1 parent b99b4aa commit 261d5eb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ <T> JdbcQueryExecution<List<T>> collectionQuery(RowMapper<T> rowMapper) {
/**
* Obtain the result type to read from {@link ResultProcessor}.
*
* @param resultProcessor
* @return
* @param resultProcessor the {@link ResultProcessor} used to determine the result type. Must not be {@literal null}.
* @return the type that should get loaded from the database before it gets converted into the actual return type of a method. Guaranteed to be not {@literal null}.
*/
protected Class<?> resolveTypeToRead(ResultProcessor resultProcessor) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ class JdbcQueryCreator extends RelationalQueryCreator<ParametrizedQuery> {
* Creates new instance of this class with the given {@link PartTree}, {@link JdbcConverter}, {@link Dialect},
* {@link RelationalEntityMetadata} and {@link RelationalParameterAccessor}.
*
* @param context
* @param context the mapping context. Must not be {@literal null}.
* @param tree part tree, must not be {@literal null}.
* @param converter must not be {@literal null}.
* @param dialect must not be {@literal null}.
* @param entityMetadata relational entity metadata, must not be {@literal null}.
* @param accessor parameter metadata provider, must not be {@literal null}.
* @param isSliceQuery
* @param returnedType
* @param isSliceQuery flag denoting if the query returns a {@link org.springframework.data.domain.Slice}.
* @param returnedType the {@link ReturnedType} to be returned by the query. Must not be {@literal null}.
*/
JdbcQueryCreator(RelationalMappingContext context, PartTree tree, JdbcConverter converter, Dialect dialect,
RelationalEntityMetadata<?> entityMetadata, RelationalParameterAccessor accessor, boolean isSliceQuery,
Expand All @@ -108,8 +108,8 @@ class JdbcQueryCreator extends RelationalQueryCreator<ParametrizedQuery> {
* Validate parameters for the derived query. Specifically checking that the query method defines scalar parameters
* and collection parameters where required and that invalid parameter declarations are rejected.
*
* @param tree
* @param parameters
* @param tree the tree structure defining the predicate of the query.
* @param parameters parameters for the predicate.
*/
static void validate(PartTree tree, Parameters<?, ?> parameters,
MappingContext<? extends RelationalPersistentEntity<?>, ? extends RelationalPersistentProperty> context) {
Expand Down Expand Up @@ -345,18 +345,6 @@ static private final class Join {
this.parentId = parentId;
}

Table getJoinTable() {
return this.joinTable;
}

Column getJoinColumn() {
return this.joinColumn;
}

Column getParentId() {
return this.parentId;
}

@Override
public boolean equals(Object o) {

Expand Down

0 comments on commit 261d5eb

Please sign in to comment.