#350 - Use Testcontainers constructor with image name.

Create database containers using the constructor accepting the image name to make sure that the exposed port gets registered. A recent change in Testcontainers caused that the port is no longer registered when using the default constructor.
spring-projects · Apr 20, 2020 · ee46695 · ee46695
1 parent 6cf4ae1
commit ee46695
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java b/src/test/java/org/springframework/data/r2dbc/testing/MariaDbTestSupport.java
@@ -107,7 +107,7 @@ private static ExternalDatabase testContainer() {
 		if (testContainerDatabase == null) {
 
 			try {
-				MariaDBContainer container = new MariaDBContainer();
+				MariaDBContainer container = new MariaDBContainer(MariaDBContainer.IMAGE + ":" + MariaDBContainer.DEFAULT_TAG);
 				container.start();
 
 				testContainerDatabase = ProvidedDatabase.builder(container) //

diff --git a/src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java b/src/test/java/org/springframework/data/r2dbc/testing/MySqlTestSupport.java
@@ -107,7 +107,7 @@ private static ExternalDatabase testContainer() {
 		if (testContainerDatabase == null) {
 
 			try {
-				MySQLContainer container = new MySQLContainer();
+				MySQLContainer container = new MySQLContainer(MySQLContainer.IMAGE + ":" + MySQLContainer.DEFAULT_TAG);
 				container.start();
 
 				testContainerDatabase = ProvidedDatabase.builder(container) //

diff --git a/src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java b/src/test/java/org/springframework/data/r2dbc/testing/PostgresTestSupport.java
@@ -88,7 +88,8 @@ private static ExternalDatabase testContainer() {
 		if (testContainerDatabase == null) {
 
 			try {
-				PostgreSQLContainer container = new PostgreSQLContainer();
+				PostgreSQLContainer container = new PostgreSQLContainer(
+						PostgreSQLContainer.IMAGE + ":" + PostgreSQLContainer.DEFAULT_TAG);
 				container.start();
 
 				testContainerDatabase = ProvidedDatabase.from(container);