Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing system property placeholder resolving in orcl:pooling-data-source [DATAJDBC-45] #301

Closed
spring-projects-issues opened this issue May 15, 2013 · 2 comments
Assignees
Labels
in: core Issues in core support type: bug A general bug
Milestone

Comments

@spring-projects-issues
Copy link

Jan Philipp opened DATAJDBC-45 and commented

After I'd found Spring Data JDBC/Oracle by surprise, I want give it a try.

I've tried following

<orcl:pooling-datasource id="dataSource" properties-location="file:${user.home}aFileInMyHomeDir.properties" />

Just like other setups (i.e. MessageSource), but this one will not work. Stepping into it resolves that ResourceLoader.getResource() will be invoked with file:${user.home}aFileInMyHomeDir.properties (not replaced) and cannot itself resolve the property.

I would say this is a bug or a missing resolving.. or did I have missed something? How can I provide database properties without a) my classpath and b) without specifying an absolute path which isn't possible when supporting multiple platforms (win/*nix).

A fallback could be defining separated connection and cache properties, however, referenced properties beans are not allowed for connection-properties and connection-cache-properties


Affects: Ext 1.0 RELEASE

Referenced from: commits spring-attic/spring-data-jdbc-ext@1966c38

@spring-projects-issues
Copy link
Author

Thomas Risberg commented

It probably doesn't resolve the expression - I'll take a look and add full SPEL support for the next maintenance release

@spring-projects-issues
Copy link
Author

Thomas Risberg commented

Added resolution of system properties for property file locations

@spring-projects-issues spring-projects-issues added type: bug A general bug in: core Issues in core support labels Dec 31, 2020
@spring-projects-issues spring-projects-issues added this to the Ext 1.1 M1 milestone Dec 31, 2020
mp911de pushed a commit that referenced this issue Feb 21, 2022
mp911de pushed a commit that referenced this issue Feb 21, 2022
mp911de pushed a commit that referenced this issue Feb 21, 2022
mp911de pushed a commit that referenced this issue Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core support type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants