Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DATAJDBC-106 - Support to specify a database object name using annotation #65

Closed
wants to merge 1 commit into from
Closed

DATAJDBC-106 - Support to specify a database object name using annotation #65

wants to merge 1 commit into from

Conversation

kazuki43zoo
Copy link
Contributor

  • Added @Table
  • Added @Column

I've fixed the DATAJDBC-106.
WDYT?

@kazuki43zoo
Copy link
Contributor Author

Could not create test container on Travis CI...

@kazuki43zoo kazuki43zoo force-pushed the DATAJDBC-106 branch 2 times, most recently from 3edab4f to 4f33e9b Compare April 21, 2018 04:54
@kazuki43zoo
Copy link
Contributor Author

I've rebased.

schauder pushed a commit that referenced this pull request May 17, 2018
@kazuki43zoo @schauder
DATAJDBC-106 - Support to specify a database object names using annot…
cd74039 
…ations.

@table and @column annotation added for configuring table and column names.

Original pull request: #65.
schauder added a commit that referenced this pull request May 17, 2018
@schauder
DATAJDBC-106 - Polishing.
46a07ac 
Formatting and Javadoc.

Original pull request: #65
@cemo
Copy link

cemo commented May 17, 2018

Hi, we have a similar library as yours and watching improvements on this project. We had to make a decision about using annotations. We decided to use JPA annotations by providing extension clarifications in our team. The best part of this decision is that I could start to use Hibernate base code generators. Our entire ddl's of tables are generated by these annotations. These annotations are including index, not null, multiple primary column etc.. support on the fly. It might be worth to think about this decision. :)

@schauder
Copy link
Contributor

That's merged. Thanks

@schauder schauder closed this May 18, 2018
@schauder
Copy link
Contributor

@cemo I don't like the idea of using JPA annotations to much. They would include lots of stuff that does nothing for Spring Data JDBC and eventually we'd still have to add our own annotations.

Of course being able to leverage existing tools is nice.

@kazuki43zoo kazuki43zoo deleted the DATAJDBC-106 branch May 18, 2018 08:20
mp911de pushed a commit that referenced this pull request Feb 21, 2022
@uaihebert @mp911de
#41 - Add R2DBC converters.
455e9a5 
Original pull request: #65.
mp911de added a commit that referenced this pull request Feb 21, 2022
@mp911de
#41 - Polishing.
3695222 
Rename RowDataConverter to R2dbcConverters. Introduce R2dbcSimpleTypeHolder. Apply custom conversions check in MappingR2dbcConverter. Extend tests.

Original pull request: #65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kazuki43zoo @cemo @schauder