Skip to content

Commit

Permalink
polish javadoc and fixmes
Browse files Browse the repository at this point in the history
  • Loading branch information
simonbasle committed May 5, 2023
1 parent 1f87111 commit 5b3ae76
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
7 changes: 3 additions & 4 deletions framework-docs/modules/ROOT/pages/integration/scheduling.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,9 @@ seconds:
[NOTE]
====
When destroying the annotated bean or closing the application context Spring Framework cancels
scheduled tasks, which includes the next scheduled subscription to the `Publisher`.
However, there is no tracking of individual subscriptions: once a subscription has started
it can't be cancelled. For that reason, it is a pre-requisite that the `Publisher` is finite
in addition to supporting multiple subsequent subscriptions.
scheduled tasks, which includes the next scheduled subscription to the `Publisher` as well
as any past subscription that is still currently active (e.g. for long-running publishers,
or even infinite publishers).
====


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
*
* <p>Methods that return a reactive {@code Publisher} or a type which can be adapted
* to {@code Publisher} by the default {@code ReactiveAdapterRegistry} are supported.
* The {@code Publisher} MUST be finite and MUST support multiple subsequent subscriptions
* (i.e. be cold).
* The {@code Publisher} MUST support multiple subsequent subscriptions (i.e. be cold).
* The returned Publisher is only produced once, and the scheduling infrastructure
* then periodically {@code subscribe()} to it according to configuration.
* Values emitted by the publisher are ignored. Errors are logged at WARN level, which
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,7 @@ void rejectCantAccessMethod() {
.withCause(new IllegalAccessException("expected"));
}

//FIXME find a way to test the case with fixedDelay effectively turning into a fixedRate ?

//FIXME test createCheckpointPublisherFor uses Reactor and checkpoint operator
//TODO find a way to test the case with fixedDelay effectively turning into a fixedRate ?

@Test
void hasCheckpointToString() {
Expand Down

0 comments on commit 5b3ae76

Please sign in to comment.